Skip to content

Remove duplicate derive Clone in macro #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Jun 13, 2025

This PR removes a duplicated derive(Clone) in hyperlight-component-util that result in a compilation error when using the wasm_guest_bindgen macro from hyperlight-wasm.

Clone is already being derived in L. 483

simongdavies
simongdavies previously approved these changes Jun 13, 2025
@jsturtevant jsturtevant enabled auto-merge (squash) June 13, 2025 14:28
@jsturtevant jsturtevant merged commit 1c33fc9 into hyperlight-dev:main Jun 13, 2025
49 of 59 checks passed
marosset pushed a commit to marosset/hyperlight that referenced this pull request Jun 13, 2025
* Remove duplicate derive Clone in macro

Signed-off-by: Jorge Prendes <[email protected]>

* Make rust-analyzer happy when evaluating the component macros

Signed-off-by: Jorge Prendes <[email protected]>

* bump Cargo.lock files

Signed-off-by: Jorge Prendes <[email protected]>

---------

Signed-off-by: Jorge Prendes <[email protected]>
marosset added a commit that referenced this pull request Jun 13, 2025
* Remove duplicate derive Clone in macro



* Make rust-analyzer happy when evaluating the component macros



* bump Cargo.lock files



---------

Signed-off-by: Jorge Prendes <[email protected]>
Co-authored-by: Jorge Prendes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix For PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants